search

MokhaLeee / fe8u-cskillsys-kernel

Morden c-skillsystem for fireemblem8u
MIT License
9 stars 5 forks source link

Unintended limitations to skill scroll functionality #351

Closed JesterWizard closed 1 hour ago

JesterWizard commented 4 hours ago

It seems the ASMC that adds a skill scroll to a unit's inventory can't do it without first removing the skill from their skills list, which makes no sense as it's not currently on their list?

MokhaLeee commented 2 hours ago

I don't understand what you mean. Can you say it in more detail?

JesterWizard commented 2 hours ago

Sure, so in debug-event.c you have a function to add a skill scroll to Ephraim, but the item usability for that skill scroll is disabled unless you call Evt_RemoveSkill on the skill in that scroll before you add it into his inventory.

I'm confused why this is necessary, as he doesn't have the skill before he learns it via scroll?

image

MokhaLeee commented 2 hours ago

because he has already learned that skill in debug mode

JesterWizard commented 2 hours ago

But he hasn't though. As you can see from my screenshot, he learns three skills in debug mode, MovBonus, Pass and Teleportation.

I went through the entire system, Fury isn't currently learned anywhere by anyone.

MokhaLeee commented 2 hours ago

https://github.com/MokhaLeee/fe8u-cskillsys-kernel/blob/main/Wizardry/Core/SkillSys/kernel/LoadSkill.c#L150

JesterWizard commented 1 hour ago

Ah I think I understand now. It's available in his list of equippable skills that's why he can't learn it.

image