search

MolSSI-Education / python_scripting_cms

Python Data and Scripting course for computational chemists
https://molssi-education.github.io/python_scripting_cms
Other
83 stars 33 forks source link

Update 04-tabular_data.md #50

Closed vincehradil closed 4 years ago

vincehradil commented 4 years ago

Add a carriage return on lines 322 and 355

Please delete this line and the text below before submitting your contribution.

Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

janash commented 4 years ago

The newlines here are not necessary. The print function should include newlines automatically.

For example, the code without newlines results in the following for the water.xyz file:

O to H1 : 0.969
O to H2 : 0.969

with a newline character at the end of the print statement, 

O to H1 : 0.969

O to H2 : 0.969

Is there a reason you think newlines need to be included, or are you seeing different behavior?

vincehradil commented 4 years ago

You are correct. I was writing to a file. In that case, I need the newlines.

On Thu, Mar 26, 2020 at 10:14 AM Jessica A. Nash notifications@github.com wrote:

The newlines here are not necessary. The print function should include newlines automatically.

For example, the code without newlines results in the following for the water.xyz file:

O to H1 : 0.969 O to H2 : 0.969

with a newline character at the end of the print statement,

O to H1 : 0.969

O to H2 : 0.969

Is there a reason you think newlines need to be included, or are you seeing different behavior?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MolSSI-Education/python_scripting_cms/pull/50#issuecomment-604488243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCRKNGFT45OK7OBQWYCX2TRJNWO3ANCNFSM4K7JQBIA .

janash commented 4 years ago

okay, great. Thanks for looking over and contributing!

vincehradil commented 4 years ago

My pleasure. Keep up the good work!

On Fri, Mar 27, 2020 at 9:51 AM Jessica A. Nash notifications@github.com wrote:

Closed #50 https://github.com/MolSSI-Education/python_scripting_cms/pull/50.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MolSSI-Education/python_scripting_cms/pull/50#event-3172739033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCRKNC2SWXJQVOKF2VZNC3RJS4PPANCNFSM4K7JQBIA .