Updates for MDI library based on static code analysis with Coverity Scan

MolSSI-MDI / MDI_Library

A library that enables code interoperability via the MolSSI Driver Interface.

BSD 3-Clause "New" or "Revised" License

31 stars 10 forks source link

Updates for MDI library based on static code analysis with Coverity Scan #159

Closed akohlmey closed 6 months ago

akohlmey commented 7 months ago

When enabling static code analysis in LAMMPS for the MDI package with Coverity Scan (https://scan.coverity.com/) also several issues were reported for the MDI library.

This pull request tries to address them. Most are peripheral and have only a minor impact, but the change in commit 78bc193021a9b099982249dbc18f1c16b8a3db13 is a real bugfix.

Please also check out issue #158

codecov[bot] commented 6 months ago

Codecov Report

Merging #159 (5a806b5) into master (54a477c) will decrease coverage by 0.27%. The diff coverage is 42.85%.

Additional details and impacted files

taylor-a-barnes commented 6 months ago

@akohlmey Thanks very much for these fixes! Sorry for the slow response - I've been out of the office for a while. The changes look good to me. I've run the CI tests, and everything looks good. The Windows test is failing for reasons unrelated to these changes.

I'll take care of issue #158, and then let you know when I've released a new patch version.