MDI_NULL_COMM naming convention?

MolSSI-MDI / MDI_Library

A library that enables code interoperability via the MolSSI Driver Interface.

BSD 3-Clause "New" or "Revised" License

31 stars 10 forks source link

Closed zerothi closed 4 years ago

zerothi commented 4 years ago

I am trying to read through your MDI work, really nice.

Wouldn't it make sense to follow MPI naming conventions?

You use MDI_NULL_COMM, but I think it would be more natural to use MDI_COMM_NULL?

taylor-a-barnes commented 4 years ago

@zerothi You're certainly correct - thanks for catching this. Feel free to point out any other inconsistencies.