Describe the bug
The nuclear repulsion energy (NRE) obtained by GAMESS and QCElemental differ by a subtle amount in the present test case (H2O2). Updating the GAMESS NRE with the QCElemental NRE in the harvester fails, even though both energies differ only by ~ 5.0e-10 Hartree.
Expected behavior
Checking up to 11 decimal places is probably too harsh, at least in this case. A possible fix would be to replace the line shown above with
Describe the bug The nuclear repulsion energy (NRE) obtained by GAMESS and QCElemental differ by a subtle amount in the present test case (H2O2). Updating the GAMESS NRE with the QCElemental NRE in the harvester fails, even though both energies differ only by ~ 5.0e-10 Hartree.
The failing line: https://github.com/MolSSI/QCEngine/blob/a206fb9f1a5d214b67e2a7124771a688a4418501/qcengine/programs/gamess/harvester.py#L27
To Reproduce
The
molecule.json
file is given below:Expected behavior Checking up to 11 decimal places is probably too harsh, at least in this case. A possible fix would be to replace the line shown above with
which would only check up to 6 decimal places I guess. But it looks somehow ugly and directly calls a dunder-method...
Additional context Occurs with Python 3.8.5 and recent versions of QCElemental and -Engine (v.0.17 in both cases).