MolSSI / QCEngine

Quantum chemistry program executor and IO standardizer (QCSchema).
https://molssi.github.io/QCEngine/
BSD 3-Clause "New" or "Revised" License
163 stars 78 forks source link

Enable geometry optimizations with MRChem #380

Closed robertodr closed 1 year ago

robertodr commented 1 year ago

Description

I've modified the MRChem harness to accept input for the calculation of molecular gradients, which allows to use it with geometry optimization procedures.

Changelog description

Status

codecov[bot] commented 1 year ago

Codecov Report

Merging #380 (982facc) into master (737ba76) will increase coverage by 0.06%. The diff coverage is 100.00%.

Additional details and impacted files
WardLT commented 1 year ago

Could you add a test that shows it works?

loriab commented 1 year ago

Thanks, this lgtm, though I agree a test would be nice. If you release https://github.com/MolSSI/QCEngine/blob/master/qcengine/tests/test_harness_canonical.py#L83, I think the MRChem lane should pass. And if you rebase (I got a branch merged last night), I think the other lanes should pass.

I'm planning to do a release today. But if this doesn't make it in, there'll probably be another before the month is out.

robertodr commented 1 year ago

Sorry for the sloppy work! I've added tests for the evaluation of the gradient and running geometry optimizations.

robertodr commented 1 year ago

I'm pretty sure the OpenMM failure is unrelated.

loriab commented 1 year ago

Modernizing the yaml loading fixes the OpenMM lane somehow, so I think this is ready to go. Any other comments or concerns, @WardLT ?

WardLT commented 1 year ago

Looks great! Thanks @robertodr !