MolSSI / QCFractal

A distributed compute and database platform for quantum chemistry.

https://molssi.github.io/QCFractal/

BSD 3-Clause "New" or "Revised" License

144 stars 47 forks source link

Make protocols field optional in pydantic models #603

Closed bennybp closed 4 years ago

bennybp commented 4 years ago

Description

The protocols field in the models was given default values but were not made optional. This would cause some older tasks (without protocols specfied in the task) to be rejected by the server when a manager tried to upload completed results.

Changelog description

Make protocols field optional to allow for re-running (some) older tasks

Status

[X] Code base linted
[ ] Ready to go

codecov[bot] commented 4 years ago

Codecov Report

Merging #603 into master will not change coverage. The diff coverage is 100.00%.