MolSSI / QCFractal

A distributed compute and database platform for quantum chemistry.

https://molssi.github.io/QCFractal/

BSD 3-Clause "New" or "Revised" License

148 stars 48 forks source link

Fix connection strings in alembic #621

Closed bennybp closed 4 years ago

bennybp commented 4 years ago

Description

In doing a migration test on the full database, I noticed that the connection string being passed to the alembic command contained stars for the password. This fixes that issue. However, it does open up a small security hole (as the password will be used on the command line and therefore show up with ps, etc).

Changelog description

Fix issue with incorrect passwords used with alembic migrations

Status

[X] Code base linted
[X] Ready to go

codecov[bot] commented 4 years ago

Codecov Report

Merging #621 into master will increase coverage by 0.00%. The diff coverage is 100.00%.