Closed dotsdl closed 2 years ago
This pull request introduces 9 alerts when merging b0c9a994355734d5296754d3a1bdc26f89244504 into 991b95c18b805dd16ea82566cbfadaa763cbcb7c - view on LGTM.com
new alerts:
This pull request introduces 8 alerts when merging d2cffc3da9749845c4205927c4323c82bfc6394e into 991b95c18b805dd16ea82566cbfadaa763cbcb7c - view on LGTM.com
new alerts:
Description
This PR features a new
PortalClient
client interface, functioning as a MVP demonstrator for the following design features:__getitem__
forBaseProcedureDataset
subclasses, such asOptimizationDataset
as the access pattern of choice for getting records from compute specs.data
to._data
from top-level interface inCollection
subclasses, treating it as an implementation detail and guiding users away from parsing it directly_
methodstqdm
to clearly indicate server communication from an action, feedback to users on wait timespandas
, in particular as a container for complex objects such asOptimizationRecord
s, where a dict or list will do;pandas
is a great tool, but can make the client cumbersome to use with low value-add in many casesThe approach taken here is informed by user feedback collected in late 2020 on the difficulty of using the current
FractalClient
. We hope to make the use of the client more obvious for users by virtue of its exposed methods, interaction patterns, and responsiveness, while also improving performance for repeated access of the same dataset(s).This approach is meant to inspire discussion, and we are early enough in the process to alter course. Please do offer feedback!
Changelog description
Status