MolSSI / QCFractal

A distributed compute and database platform for quantum chemistry.

https://molssi.github.io/QCFractal/

BSD 3-Clause "New" or "Revised" License

144 stars 47 forks source link

Small shim in `FractalClient.query_results` for old Result models #675

Closed dotsdl closed 3 years ago

dotsdl commented 3 years ago

Addresses #674.

There are some datasets in the database with old QCElemental result models that fail validation when queries. These are retruned by FractalClient._automodel_request as dictionaries, even without include specified. This shim handles these cases as gracefully as we can at this time until the old results are migrated to the new result model.

Description

Changelog description

Status

[ ] Code base linted
[ ] Ready to go

codecov[bot] commented 3 years ago

Codecov Report

Merging #675 (16e7585) into master (f622600) will decrease coverage by 0.48%. The diff coverage is 66.66%.

dotsdl commented 3 years ago

This PR will quickly become irrelevant given upcoming migration work.