[next branch] `QueueManagerSettings` is lacking `env_prefix` - Githubissues

MolSSI / QCFractal

A distributed compute and database platform for quantum chemistry.

https://molssi.github.io/QCFractal/

BSD 3-Clause "New" or "Revised" License

144 stars 47 forks source link

[next branch] `QueueManagerSettings` is lacking `env_prefix` #726

Closed hadim closed 1 year ago

hadim commented 1 year ago

See https://github.com/MolSSI/QCFractal/blob/27042bdaf45cc089fa846611a83ac47477d40364/qcfractalcompute/qcfractalcompute/qcfractal_manager_cli.py#LL156C14-L156C14

It would make it easier to configure a manager using env variables (useful in a cloud dev setup).

The other setting objects are using the same "QCA_" prefix which could lead to collision in the future.

Maybe all the settings in qcfractal_manager_cli.py should have a dedicated prefix. The same ways it is for QCF_?

What do you think? Happy to propose a PR if it can help.

hadim commented 1 year ago

I guess this is not relevant anymore since qcfractal-compute-manager should be preferred.