Enable Pydantic v1/v2 dual-compatibility

MolSSI / QCFractal

A distributed compute and database platform for quantum chemistry.

https://molssi.github.io/QCFractal/

BSD 3-Clause "New" or "Revised" License

143 stars 47 forks source link

Enable Pydantic v1/v2 dual-compatibility #787

Closed mattwthompson closed 8 months ago

mattwthompson commented 8 months ago

Description

This is my attempt at taking #736 over the finish line

Changelog description

Status

[ ] Code base linted
[x] Ready to go

closes #736

loriab commented 8 months ago

I don't have official powers here at qcf, so merge decision/schedule is all @bennybp .

bennybp commented 8 months ago

Thanks! I also removed the pins in some testing environments.

I remember there being some error with pydantic-settings being a separate package. Has that changed recently? It isn't in the dependency lists but everything seems to work

mattwthompson commented 8 months ago

My guess is you're thinking of this issue: https://github.com/MolSSI/QCElemental/issues/312

In which case it's still a problem, but under the umbrella of changes required to leverage the v2 API. Since this just allows access to v1 via v2 I think that can still be pushed into the future.

bennybp commented 8 months ago

Oh yes, of course :) Thanks for finishing this up!

mattwthompson commented 8 months ago

Thank you!