Lnaden commented 2 years ago

Fixes #112

An edge case when packages are made by pulling the source code tarballs from GitHub does not include the {{package}}/_version.py file.

codecov[bot] commented 2 years ago

Codecov Report

Merging #147 (1cc5b3a) into master (918de2a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   61.53%   61.53%           
=======================================
  Files          12        8    -4     
  Lines          78       52   -26     
=======================================
- Hits           48       32   -16     
+ Misses         30       20   -10

Flag	Coverage Δ
unittests	`61.53% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
prj_1_3_1/prj_1_3_1/__init__.py
prj_1_3_1/prj_1_3_1/prj_1_3_1.py
prj_1_3_2/prj_1_3_2/prj_1_3_2.py
prj_1_3_2/prj_1_3_2/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 918de2a...1cc5b3a. Read the comment docs.

mattwthompson commented 2 years ago

To put my mind at ease, here's another case that doesn't use namespace packages, and it looks like it should be just the same: https://github.com/choderalab/openmmtools/pull/496/files

MolSSI / cookiecutter-cms

Add a .gitattributes file for versioneer to via GitHub #147

Codecov Report