Molara-Lab / Molara

Molara is a Python package for the visualization of chemical structures such as molecules or crystals. It provides a graphical user interface for importing structures from output files of popular computational chemistry software as well as for creating custom structures.
GNU General Public License v3.0
14 stars 0 forks source link

Bonds should be drawn with draw_cylinders, Atoms with draw_spheres #313

Open adrianusler opened 7 months ago

adrianusler commented 7 months ago

Currently, the drawing of bonds happens somewhere else, apparently. Even when draw_cylinders (rendering.py) is completely deactivated, bonds still work...

Michel-Heinz commented 6 months ago

Yes this is true! However, I did this to write a separate routine to speed up the drawing of large or a lot of molecules. I would not like to combine these things. Draw_spheres and draw_cylinders were programmed to draw small objects not computationally expensive ones.

adrianusler commented 6 months ago

Couldn't we wrap your more performant code into those routines?

Michel-Heinz commented 6 months ago

I cannot remember what I wrote there, only that it was not that easy to merge these bits.