Closed ab5424 closed 6 months ago
@adrianusler There are a few errors in the pre-commit, do you have a quick fix for them?
src/molara/Gui/supercell_dialog.py:75: error: Unsupported target for indexed assignment ("Sequence[int]") [index]
src/molara/Gui/supercell_dialog.py:76: error: Unsupported target for indexed assignment ("Sequence[int]") [index]
src/molara/Gui/supercell_dialog.py:77: error: Unsupported target for indexed assignment ("Sequence[int]") [index]
src/molara/Gui/structure_widget.py:354: error: "Structure" has no attribute "basis_vectors" [attr-defined]
src/molara/Gui/measuring_tool_dialog.py:66: error: List item 0 has incompatible type "None"; expected "str" [list-item]
src/molara/Gui/main_window.py:180: error: Incompatible return value type (got "None", expected "bool") [return-value]
Codecov Report
Attention: Patch coverage is
29.41176%
with12 lines
in your changes are missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #321 +/- ## ========================================== - Coverage 27.28% 27.27% -0.02% ========================================== Files 37 37 Lines 3126 3124 -2 ========================================== - Hits 853 852 -1 + Misses 2273 2272 -1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.