search

Molara-Lab / Molara

Molara is a Python package for the visualization of chemical structures such as molecules or crystals. It provides a graphical user interface for importing structures from output files of popular computational chemistry software as well as for creating custom structures.
GNU General Public License v3.0
11 stars 0 forks source link

Fixed bug: Wrong dtype in cylinder rendering #323

Closed RealUranar closed 4 months ago

RealUranar commented 4 months ago

Fixed the bug by adding a bunch of np.float32 type-hints and adding a new norm_float function.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.09%. Comparing base (cd05cb4) to head (208938d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #323 +/- ## ======================================= Coverage 67.09% 67.09% ======================================= Files 38 38 Lines 3158 3158 ======================================= Hits 2119 2119 Misses 1039 1039 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adrianusler commented 4 months ago

Nice work @RealUranar! Please try to be more specific in titles of issues and Pull Requests.