Closed adrianusler closed 5 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are limited to the following labels: . Please add one of these labels to enable auto reviews.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 92.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 70.81%. Comparing base (
bd5212b
) to head (f3d1c10
).
Files | Patch % | Lines |
---|---|---|
src/molara/Structure/io/importer.py | 92.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Simplifications are always good, do we have good test coverage of this? Else have you tried if this works? :) According to code cov the test coverage would decrease marginally, can you also cover your changes?
do we have good test coverage of this?
Except for 2 lines, the changes are covered. I think that the corresponding lines were also not covered before (they refer to a case when the atomic number is provided in the .xyz instead of an element symbol).
I simplified the code in the XyzImporter class. I think it makes sense to merge this part sooner than the rest of what I'm implementing in the feature/363-... branch, therefore I made this "spinoff" branch.