Closed adrianusler closed 2 months ago
The recent updates focus on enhancing camera settings management in the molara
software package. New functionalities for exporting and importing camera settings have been added both in the GUI and the testing framework, improving user interaction and testing robustness.
File Path | Change Summary |
---|---|
.../rendering/test_camera.py |
Updated methods and imports for camera testing; added new methods for handling camera settings. |
src/molara/Gui/main_window.py |
Added methods for exporting and importing camera settings via GUI triggers. |
🐇 A CodeRabbit's Ode to Changes 🎉
In the realm of code, where cameras play, New paths we pave, old ones we fray. Export, import, settings anew, Testing the changes, through and through. Hop along, dear code, take flight, For in these updates, we find our delight. 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 76.82927%
with 19 lines
in your changes are missing coverage. Please review.
Project coverage is 75.19%. Comparing base (
69e8c76
) to head (90f4664
).
Files | Patch % | Lines |
---|---|---|
src/molara/Gui/main_window.py | 22.22% | 14 Missing :warning: |
src/molara/Gui/structure_widget.py | 40.00% | 3 Missing :warning: |
src/molara/Rendering/camera.py | 93.54% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have merged the PR on the structure customizer. I would like you to use the same interface, where you save the settings in a .json file in the settings/camera directory. You can use the code I wrote in the structure customizer dialog as a reference. Or do you like keeping it a separate format?
I am of the same opinion as Michel. I think we should use the same file format for all settings. .json are imo a good option for this. Still .yaml and .toml files would be other options.
I think we should discuss this on the next hackathon.
I have changed the file format from .npz to .json @Michel-Heinz @GereonFeldmann
Works for me 👍. Can you include the export camera settings to the export that is already there? If you hover ove the export button a new drop down menu should appear with camera and snapshot. I would also suggest moving the import camera setting to the import button, I almost did not find the option. :)
Works for me 👍. Can you include the export camera settings to the export that is already there? If you hover ove the export button a new drop down menu should appear with camera and snapshot. I would also suggest moving the import camera setting to the import button, I almost did not find the option. :)
Done @Michel-Heinz.
top 👍
It is now possible to export (/import) camera settings to (/from) an .json file.
Still to be done:
tempfile
module instead of deleting file withPath(...).unlink()
[see coderabbit]To be done in future work: Adapt window size to the specified width/height values?