Molara-Lab / Molara

Molara is a Python package for the visualization of chemical structures such as molecules or crystals. It provides a graphical user interface for importing structures from output files of popular computational chemistry software as well as for creating custom structures.
GNU General Public License v3.0
11 stars 0 forks source link

Implement export and import of camera settings #366

Closed adrianusler closed 2 months ago

adrianusler commented 2 months ago

It is now possible to export (/import) camera settings to (/from) an .json file.

Still to be done:

To be done in future work: Adapt window size to the specified width/height values?

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent updates focus on enhancing camera settings management in the molara software package. New functionalities for exporting and importing camera settings have been added both in the GUI and the testing framework, improving user interaction and testing robustness.

Changes

File Path Change Summary
.../rendering/test_camera.py Updated methods and imports for camera testing; added new methods for handling camera settings.
src/molara/Gui/main_window.py Added methods for exporting and importing camera settings via GUI triggers.

Poem

🐇 A CodeRabbit's Ode to Changes 🎉

In the realm of code, where cameras play, New paths we pave, old ones we fray. Export, import, settings anew, Testing the changes, through and through. Hop along, dear code, take flight, For in these updates, we find our delight. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 76.82927% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 75.19%. Comparing base (69e8c76) to head (90f4664).

Files Patch % Lines
src/molara/Gui/main_window.py 22.22% 14 Missing :warning:
src/molara/Gui/structure_widget.py 40.00% 3 Missing :warning:
src/molara/Rendering/camera.py 93.54% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #366 +/- ## ========================================== + Coverage 74.77% 75.19% +0.41% ========================================== Files 44 44 Lines 3731 3797 +66 ========================================== + Hits 2790 2855 +65 - Misses 941 942 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Michel-Heinz commented 2 months ago

I have merged the PR on the structure customizer. I would like you to use the same interface, where you save the settings in a .json file in the settings/camera directory. You can use the code I wrote in the structure customizer dialog as a reference. Or do you like keeping it a separate format?

GereonFeldmann commented 2 months ago

I am of the same opinion as Michel. I think we should use the same file format for all settings. .json are imo a good option for this. Still .yaml and .toml files would be other options.

I think we should discuss this on the next hackathon.

adrianusler commented 2 months ago

I have changed the file format from .npz to .json @Michel-Heinz @GereonFeldmann

Michel-Heinz commented 2 months ago

Works for me 👍. Can you include the export camera settings to the export that is already there? If you hover ove the export button a new drop down menu should appear with camera and snapshot. I would also suggest moving the import camera setting to the import button, I almost did not find the option. :)

adrianusler commented 2 months ago

Works for me 👍. Can you include the export camera settings to the export that is already there? If you hover ove the export button a new drop down menu should appear with camera and snapshot. I would also suggest moving the import camera setting to the import button, I almost did not find the option. :)

Done @Michel-Heinz.

Michel-Heinz commented 2 months ago

top 👍