Molara-Lab / Molara

Molara is a Python package for the visualization of chemical structures such as molecules or crystals. It provides a graphical user interface for importing structures from output files of popular computational chemistry software as well as for creating custom structures.
GNU General Public License v3.0
14 stars 0 forks source link

Issue 372: logarithmic scaling of zoom factor #383

Closed DariaBabushkina closed 4 months ago

DariaBabushkina commented 4 months ago

Added a logarithmic scaling of the zoom, so that it works properly with large systems.

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate Limit Exceeded

@adrianusler has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 5 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between cb211c1e3ded77b3186c99f864a1bd729bcf7b3e and e6b14f71183321bd7437d981e82d540312d96fbe.

Walkthrough

The recent modifications in the Molara project involve updating the calculation of camera distance in the camera.py file using a logarithmic approach. Correspondingly, the test for this function in test_camera.py has been adjusted to align with the new calculation method, enhancing the precision and responsiveness of camera zoom functionality.

Changes

Files Change Summary
.../Rendering/camera.py Updated set_distance_from_target to use a logarithmic function for distance calculation.
.../rendering/test_camera.py Modified test_set_distance_from_target to align test calculations with the new logarithmic method.

🐰✨ A leap in the code, a hop in the test, Logarithmic zoom, now simply the best. With each commit, the changes we trust, In numbers we find, a logarithmic thrust. 🎉🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
ab5424 commented 4 months ago

@DariaBabushkina I think you meant to request a merge into mainand not my branch (housekeeping/pyright), right?

adrianusler commented 4 months ago

Would it make sense to create a new pull request @ab5424 @DariaBabushkina? This one seems to be a bit messy because of the thing with the base branch

DariaBabushkina commented 4 months ago

I'll close this pull request for now and look into it. I am unsure whether I created the branch with a wrong base or sth happened in the meantime.

Sorry for the confusion! And thanks for the notice from both of you @ab5424 @adrianusler

Would it make sense to create a new pull request @ab5424 @DariaBabushkina? This one seems to be a bit messy because of the thing with the base branch

adrianusler commented 4 months ago

Just make a new Pull Request, @DariaBabushkina

adrianusler commented 4 months ago

I think nothing is wrong with your branch

adrianusler commented 4 months ago

Well done, @ab5424! I was wondering how this could be solved

ab5424 commented 4 months ago

@DariaBabushkina I reverted all changes that came from my branch.

@adrianusler That's not the case, the branch was created from my branch so it included all changes I made. A new pull request won't fix this.

adrianusler commented 4 months ago

@adrianusler That's not the case, the branch was created from my branch so it included all changes I made. A new pull request won't fix this.

Yes, I saw that when I also tried to make a "fresh" Pull Request and these commits kept showing up

ab5424 commented 4 months ago

I did git restore --source origin/main <filename> on all affected files.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.81%. Comparing base (79e3896) to head (e6b14f7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #383 +/- ## ======================================= Coverage 71.81% 71.81% ======================================= Files 40 40 Lines 3474 3474 ======================================= Hits 2495 2495 Misses 979 979 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adrianusler commented 4 months ago

The zooming works much better now, @DariaBabushkina! Thanks for your contribution.

Michel-Heinz commented 4 months ago

I tested this this morning and the zooming feels just perfect 👍