Closed DariaBabushkina closed 4 months ago
[!WARNING]
Rate Limit Exceeded
@adrianusler has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 5 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between cb211c1e3ded77b3186c99f864a1bd729bcf7b3e and e6b14f71183321bd7437d981e82d540312d96fbe.
The recent modifications in the Molara project involve updating the calculation of camera distance in the camera.py
file using a logarithmic approach. Correspondingly, the test for this function in test_camera.py
has been adjusted to align with the new calculation method, enhancing the precision and responsiveness of camera zoom functionality.
Files | Change Summary |
---|---|
.../Rendering/camera.py |
Updated set_distance_from_target to use a logarithmic function for distance calculation. |
.../rendering/test_camera.py |
Modified test_set_distance_from_target to align test calculations with the new logarithmic method. |
🐰✨ A leap in the code, a hop in the test, Logarithmic zoom, now simply the best. With each commit, the changes we trust, In numbers we find, a logarithmic thrust. 🎉🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@DariaBabushkina I think you meant to request a merge into main
and not my branch (housekeeping/pyright
), right?
Would it make sense to create a new pull request @ab5424 @DariaBabushkina? This one seems to be a bit messy because of the thing with the base branch
I'll close this pull request for now and look into it. I am unsure whether I created the branch with a wrong base or sth happened in the meantime.
Sorry for the confusion! And thanks for the notice from both of you @ab5424 @adrianusler
Would it make sense to create a new pull request @ab5424 @DariaBabushkina? This one seems to be a bit messy because of the thing with the base branch
Just make a new Pull Request, @DariaBabushkina
I think nothing is wrong with your branch
Well done, @ab5424! I was wondering how this could be solved
@DariaBabushkina I reverted all changes that came from my branch.
@adrianusler That's not the case, the branch was created from my branch so it included all changes I made. A new pull request won't fix this.
@adrianusler That's not the case, the branch was created from my branch so it included all changes I made. A new pull request won't fix this.
Yes, I saw that when I also tried to make a "fresh" Pull Request and these commits kept showing up
I did git restore --source origin/main <filename>
on all affected files.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.81%. Comparing base (
79e3896
) to head (e6b14f7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The zooming works much better now, @DariaBabushkina! Thanks for your contribution.
I tested this this morning and the zooming feels just perfect 👍
Added a logarithmic scaling of the zoom, so that it works properly with large systems.