Open Michel-Heinz opened 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent updates focus on enhancing the user interface and packaging of the Molara project. Changes include the addition of a logo in the README and application icon, adjustments to file inclusion for packaging, and an update to spell-check settings to exclude SVG files.
File(s) | Summary of Changes |
---|---|
.pre-commit-config.yaml , MANIFEST.in |
Updated to exclude .svg files and include .json files and logo image for packaging. |
README.md , src/.../__main__.py |
Introduced project logo in README and as application window icon. |
src/.../__main__.py , tests/.../test_main_program.py |
Enhanced GUI features and added relevant tests. |
π°β¨
In the code where bytes align,
A logo shines, pure and fine.
With each commit, we refine,
Crafting code that's near divine.
Hop along the binary vine! πΏπ
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 50.00000%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 79.16%. Comparing base (
0ef5cc3
) to head (eb9dd54
).
Files | Patch % | Lines |
---|---|---|
src/molara/__main__.py | 50.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Michel-Heinz codespell
is ok. The png file look horrible for it's size though.
@Michel-Heinz
codespell
is ok. The png file look horrible for it's size though.
Yes it does I ll fix it
The molara logo will now be displayed instead of the default python logo in the taskbar when using the program. I also refworked the logo for better resolution feel free to merge!
@ab5424 this is read to merge. I propose we ignore the code cov, since the coverage is increased by this patch and we cannot test the main routine anyway, because we cannot close the program in tests due to the event loop.
@Michel-Heinz For me it works on MacOS, but not on Windows (still shows the default python logo in the taskbar). I think this is a known problem: https://stackoverflow.com/questions/12432637/setting-the-windows-taskbar-icon-in-pyqt Shall we still merge and open a new issue or do you want to fix this now?
I d like to merge now and fix this later on windows. I currently do not have a windows computer on hand.
@Michel-Heinz You can use the Windows Cluster (https://help.itc.rwth-aachen.de/service/t4ibytwt1n3p/article/142725a3a4f14e4cbb0c66e00bacfbf7/), at least until 01. July when it will be discontinued.
@Michel-Heinz The logo (and json files) are now included in the build, but there is still something missing when installing the wheel:
(Molara) alexbonkowski@182-151 Molara % molara examples/xyz/ferrocene.xyz
Traceback (most recent call last):
File "/Users/alexbonkowski/PycharmProjects/venv/Molara/bin/molara", line 8, in <module>
sys.exit(main())
File "/Users/alexbonkowski/PycharmProjects/venv/Molara/lib/python3.9/site-packages/molara/__main__.py", line 36, in main
widget = MainWindow()
File "/Users/alexbonkowski/PycharmProjects/venv/Molara/lib/python3.9/site-packages/molara/Gui/main_window.py", line 57, in __init__
self.structure_customizer_dialog = StructureCustomizerDialog(self)
File "/Users/alexbonkowski/PycharmProjects/venv/Molara/lib/python3.9/site-packages/molara/Gui/structure_customizer_dialog.py", line 43, in __init__
self.update_settings_box()
File "/Users/alexbonkowski/PycharmProjects/venv/Molara/lib/python3.9/site-packages/molara/Gui/structure_customizer_dialog.py", line 77, in update_settings_box
for f in listdir(f"{self.src_path}/Settings/Structure")
FileNotFoundError: [Errno 2] No such file or directory: '/Users/alexbonkowski/PycharmProjects/venv/Molara/lib/python3.9/Settings/Structure'
I assume this will be changed anyway when we shift the settings file to home?
I added the .svg and .png file of the molara logo to the repo. I excluded some codespell string. @ab5424 can you check that please?