Converting audio files will break album art

MoleMan1024 / audiowagon

AudioWagon will play audio files from an attached USB flash drive in cars equipped with Android Automotive OS

https://moleman1024.github.io/audiowagon/

GNU General Public License v3.0

58 stars 18 forks source link

Converting audio files will break album art #118

Closed MoleMan1024 closed 1 year ago

MoleMan1024 commented 1 year ago

Describe the issue Received by e-mail:

create .m4a file with embedded album art
index that file
convert .m4a file to .mp3 file with same tags and embedded album art
delete .m4a file
index that new file
album art will not show for .mp3 file because database still points to old .m4a file because artist/album/title did not change

Expected behavior

album art should show

AudioWagon version 2.3.8

MoleMan1024 commented 1 year ago

After briefly checking the error is here I think:

https://github.com/MoleMan1024/audiowagon/blob/8f4326d1da1808c056388ee1afe3c8991c474c64/automotive/src/main/java/de/moleman1024/audiowagon/repository/RepositoryUpdate.kt#LL110C25-L110C25

Just comparing by name and artist ID is not sufficient, because those will not change in that case, the album art field needs to be updated if necessary as well.

MoleMan1024 commented 1 year ago

This will be fixed in next version

MoleMan1024 commented 1 year ago

will be in version 2.3.10