MolecularAI / Reinvent

Apache License 2.0
338 stars 110 forks source link

Numpy 1.17 version is too high resulting in an error #12

Closed zhouhao-learning closed 4 years ago

zhouhao-learning commented 4 years ago

Hello, install numpy 1.17 according to the environment version you provided, but I encountered the following problems when executing the create_model mode:

/home/zh/sda3/Anaconda3/envs/reinvent_2.0/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint8 = np.dtype([("qint8", np.int8, 1)])
/home/zh/sda3/Anaconda3/envs/reinvent_2.0/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/home/zh/sda3/Anaconda3/envs/reinvent_2.0/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint16 = np.dtype([("qint16", np.int16, 1)])
/home/zh/sda3/Anaconda3/envs/reinvent_2.0/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/home/zh/sda3/Anaconda3/envs/reinvent_2.0/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint32 = np.dtype([("qint32", np.int32, 1)])
/home/zh/sda3/Anaconda3/envs/reinvent_2.0/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  np_resource = np.dtype([("resource", np.ubyte, 1)])

When I reinstalled numpy==1.16.4, I executed the command again without any errors,

So do you need to modify the provided environmental dependencies?

patronov commented 4 years ago

Hi, this isnt an error. It is just a warning about potential future issues between tensorboard and numpy. You can still use numpy 1.17 and that will not impact the results.

While on the versioning topic probably worth mentioning that the predictive models we supply as an example are pickled with older version of sckit-learn and from version 0.22 onwards they might break. So if you want to use newer versions of scikit-learn you will have to make your own predictive models.

zhouhao-learning commented 4 years ago

@patronov I think the new prediction model you can provide is the best result

patronov commented 4 years ago

Upgrading to scikit-learn 0.22 (or higher) will happen with the next major feature release. Until then however we are not planning an update on the provided example models since this drags along environment changes and the need to properly test the code (and possibly adapt certain parts).