search

MolecularAI / aizynthfinder

A tool for retrosynthetic planning
https://molecularai.github.io/aizynthfinder/
MIT License
571 stars 130 forks source link

Update `more-itertools` dependency #107

Closed chajath closed 1 year ago

chajath commented 1 year ago

Checked more-itertools' version 9 release note and this repo doesn't make use of any functions that could have potentially breaking changes

SGenheden commented 1 year ago

What is the motivation for this PR? You would also need to to run poetry update to update the poetry.lock file and commit that.

chajath commented 1 year ago

@SGenheden thanks for the reply! I just ran poetry update more-itertools to update the lock file.

The motivation for us is to keep this package's dependency flexible enough to not conflict with other dependencies we use. Since more-itertools has widespread use, it is foreseeable that some packages might require a higher version in the near future.

I've checked more-itertools' change log, and this package isn't using any functions that can potentially break, so I thought this would be a safe change.

SGenheden commented 1 year ago

I will close this as the PR #112 for the new release are removing the dependency to more-itertools. We only used it in one place, so for maintenance reason it is better to implement this function natively in the code.