MacOS tensorflow

[MKCarter]

Hey,

This is more of a comment than an issue, but for any M1 Mac user - the pip install of tensorflow will cause this error:

zsh: illegal hardware instruction aizynthapp --config config.yml

God bless Apple! To avoid this anyone using an M1 Mac will need to:

pip uninstall tensorflow

Then:

pip install tensorflow-macos

After this, the app will work as expected. :)

Really cool to see the pip install for this app! Keep up the great work.

[SGenheden]

Hello Mike,

Thanks for this.

We can add a note on this in the installation instructions. As far as I know, M1 is still not supported officially by Tensorflow. So getting this smoothly into the installation of AiZynthFinder could be a mess.

We are also investigating the possibility to remove the Tensorflow dependency, which would solve this issue as well.

But for now, I will make a note in the README.

[churnikov]

https://github.com/MolecularAI/aizynthfinder/pull/103

I hope this PR fixes this issue. At least I certainly can use tf on m1 based machine

[SGenheden]

Hello @churnikov and @MKCarter ! We have new PR #112 for a new release. In this release we are moving to having tensorflow as an optional dependency. We have decided to base our tool primarily on ONNX models, as this offer faster start-up and inference. We have converted all our models to ONNX and they can be downloaded with the usual script. We are therefore reluctant to officially support Tensorflow for Mac as this adds maintenance. If you are willing, we would be more than happy for you to test the 3.7.0 release branch on your Mac with the ONNX models and provide us with some feedback. We have had some issues with the latest version of Poetry, but hopefully you should be able to install the package.

[Lakshidaa]

Closing due to inactivity.