Molina-Valero / FORTLS

Automatic Processing of Terrestrial-Based Technologies Point Cloud Data for Forestry Purposes
https://CRAN.R-project.org/package=FORTLS
21 stars 7 forks source link

Error in deldir #5

Closed flottsam closed 2 years ago

flottsam commented 2 years ago

I'm trying to understand the meaning of this error message when running the metrics.variables function on multiple TLS scans:

Error in deldir(pts@coords[, 1], pts@coords[, 2], rw = rw, suppressMsge = TRUE) : 
  There is at most one point inside the given
  rectangular window. Thus there are insufficiently
  many points to triangulate/tessellate.

The scan that the function fails on (scan #2 in the list of scans) does not actually contain trees. I assume that the function fails because no trees were detected. If this is the case, it would make more sense to have the function output NA, and keep processing the remaining scans.

Molina-Valero commented 2 years ago

Dear cwadeross,

I think you are using the B version of FORTLS, because you are talking about TLS multiple scans. In that case, we are updating the metrics.variables funtion. However, problems with no detected trees must appear before (in tree.detection.several.plots I guess). This means you should not have trees belonging to your scan #2 and therefore, in metrics.variables the function will jump to the scan #3 because there are not rows in the tree list belonging to #2. Another possible problem may be with the plot center coordinates...

Maybe you could pass me your data to see what happen?

Best regards, Juan Alberto

flottsam commented 2 years ago

Thank you for the quick response. Here's a subset of the raw scans: https://drive.google.com/drive/folders/1ndraIrCAqtYaOffpRPg6iSMhS21Y6jm6?usp=sharing Each of these scans contains trees, but I receive the above error on plot 10 and plot 25.

Very nice package!

Molina-Valero commented 2 years ago

I think they are single scans of TLS. Is that right? In that case, I will need the resolution as follow:

tls.resolution List containing parameters of TLS resolution. This can be defined by the angle aperture: • horizontal.angle: horizontal angle aperture (degrees). • vertical.angle: vertical angle aperture (degrees). or separation between two consecutive points at a certain distance from TLS: • point.dist: distance (mm) between two consecutive points. • tls.dist: distance (m) from TLS at which two consecutive points are separated by point.dist.

Best regards, Juan Alberto

flottsam commented 2 years ago

Hmm, yes single scan from a Leica BLK360. I'll see if I can find the spec sheet, I did not take the scans myself.

flottsam commented 2 years ago

I was able to find this in the manual online. Using the high density mode, the resolution should be 5mm at 10 m distance.

Molina-Valero commented 2 years ago

Thank you! I will check it asap

Molina-Valero commented 2 years ago

I sent you an email. Please, let me know if you received it

flottsam commented 2 years ago

Hello Juan,

I've been busy with field work, but have had a chance to go through the code this morning. I can't seem to get the metrics.variable function to find the output (.txt) files. I've triple-checked the file paths, and they are correct. The dir.data and dir.result are using the same path. The output .txt files have the same names as the scans, but I keep receiving the error:

Error in .sim.calc(funct = "metr", tree.list.tls = tree.list.tls, tree.list.ds = tree.list.ds, : TXT file(s) 'plot_1.1.las.txt', 'plot_2.1.las.txt' in 'tree.list.tls' argument does(do) not exists in the directory specified in 'dir.data' argument.

Any suggestions?

-wade

On Mon, Jan 24, 2022 at 1:23 PM Juan Alberto Molina-Valero < @.***> wrote:

I sent you an email. Please, let me know if you received it

— Reply to this email directly, view it on GitHub https://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1020406176, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXMCS2XXTDEUWVSKLF7HZDUXWKLXANCNFSM5L7UOKYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

Molina-Valero commented 2 years ago

Hello,

Please, check that the output .txt files have the same names as the column file in the tree.list.tls data frame. They must be coincident.

Let me known if you have solved this issue.

Best, Juan

De: cross @.> Enviado el: lunes, 7 de febrero de 2022 17:40 Para: Molina-Valero/FORTLS @.> CC: MOLINA VALERO JUAN ALBERTO @.>; Comment @.> Asunto: Re: [Molina-Valero/FORTLS] Error in deldir (Issue #5)

Hello Juan,

I've been busy with field work, but have had a chance to go through the code this morning. I can't seem to get the metrics.variable function to find the output (.txt) files. I've triple-checked the file paths, and they are correct. The dir.data and dir.result are using the same path. The output .txt files have the same names as the scans, but I keep receiving the error:

Error in .sim.calc(funct = "metr", tree.list.tls = tree.list.tls, tree.list.ds = tree.list.ds, : TXT file(s) 'plot_1.1.las.txt', 'plot_2.1.las.txt' in 'tree.list.tls' argument does(do) not exists in the directory specified in 'dir.data' argument.

Any suggestions?

-wade

On Mon, Jan 24, 2022 at 1:23 PM Juan Alberto Molina-Valero < @.***> wrote:

I sent you an email. Please, let me know if you received it

— Reply to this email directly, view it on GitHub https://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1020406176, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXMCS2XXTDEUWVSKLF7HZDUXWKLXANCNFSM5L7UOKYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1031675484, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMNW6HSGSZMO253BIMC2HX3UZ7YXJANCNFSM5L7UOKYA. You are receiving this because you commented.Message ID: @.***>

flottsam commented 2 years ago

Hey Juan,

Disregard that email, I noticed that the dir.data and dir.result arguments were wrapped inside the plot.parameters argument.

-wade

On Mon, Feb 7, 2022 at 11:39 AM wade ross @.***> wrote:

Hello Juan,

I've been busy with field work, but have had a chance to go through the code this morning. I can't seem to get the metrics.variable function to find the output (.txt) files. I've triple-checked the file paths, and they are correct. The dir.data and dir.result are using the same path. The output .txt files have the same names as the scans, but I keep receiving the error:

Error in .sim.calc(funct = "metr", tree.list.tls = tree.list.tls, tree.list.ds = tree.list.ds, : TXT file(s) 'plot_1.1.las.txt', 'plot_2.1.las.txt' in 'tree.list.tls' argument does(do) not exists in the directory specified in 'dir.data' argument.

Any suggestions?

-wade

On Mon, Jan 24, 2022 at 1:23 PM Juan Alberto Molina-Valero < @.***> wrote:

I sent you an email. Please, let me know if you received it

— Reply to this email directly, view it on GitHub https://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1020406176, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXMCS2XXTDEUWVSKLF7HZDUXWKLXANCNFSM5L7UOKYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

flottsam commented 2 years ago

Thanks again for the speedy response. I was testing on a very small set and will run this again.

-wade

On Mon, Feb 7, 2022 at 11:50 AM Juan Alberto Molina-Valero < @.***> wrote:

Hello,

Please, check that the output .txt files have the same names as the column file in the tree.list.tls data frame. They must be coincident.

Let me known if you have solved this issue.

Best, Juan

De: cross @.> Enviado el: lunes, 7 de febrero de 2022 17:40 Para: Molina-Valero/FORTLS @.> CC: MOLINA VALERO JUAN ALBERTO @.>; Comment @.> Asunto: Re: [Molina-Valero/FORTLS] Error in deldir (Issue #5)

Hello Juan,

I've been busy with field work, but have had a chance to go through the code this morning. I can't seem to get the metrics.variable function to find the output (.txt) files. I've triple-checked the file paths, and they are correct. The dir.data and dir.result are using the same path. The output .txt files have the same names as the scans, but I keep receiving the error:

Error in .sim.calc(funct = "metr", tree.list.tls = tree.list.tls, tree.list.ds = tree.list.ds, : TXT file(s) 'plot_1.1.las.txt', 'plot_2.1.las.txt' in 'tree.list.tls' argument does(do) not exists in the directory specified in 'dir.data' argument.

Any suggestions?

-wade

On Mon, Jan 24, 2022 at 1:23 PM Juan Alberto Molina-Valero < @.***> wrote:

I sent you an email. Please, let me know if you received it

— Reply to this email directly, view it on GitHub < https://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1020406176>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXMCS2XXTDEUWVSKLF7HZDUXWKLXANCNFSM5L7UOKYA>

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub< https://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1031675484>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AMNW6HSGSZMO253BIMC2HX3UZ7YXJANCNFSM5L7UOKYA>.

You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1031686697, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXMCS3MPF2GRUZOG7ZJNBTUZ7Z53ANCNFSM5L7UOKYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

Molina-Valero commented 2 years ago

OK. If you install the lastest version, please run all the code from the beginning because we often update the beta version.

flottsam commented 2 years ago

Will do, thanks!

-wade

On Mon, Feb 7, 2022 at 11:57 AM Juan Alberto Molina-Valero < @.***> wrote:

OK. If you install the lastest version, please run all the code from the beginning because we often update the beta version.

— Reply to this email directly, view it on GitHub https://github.com/Molina-Valero/FORTLS/issues/5#issuecomment-1031693625, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXMCS3SMKKLWZCZ7LIROYTUZ72XZANCNFSM5L7UOKYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>