Add colors for my specific Network equipments (Schirrms)

Molkobain / itop-datacenter-view

Extension for iTop: Easily manage & visualize your racks, enclosures and datacenter devices.

28 stars 14 forks source link

Add colors for my specific Network equipments (Schirrms) #11

Closed Schirrms closed 4 years ago

Schirrms commented 4 years ago

Hi Molkobain,

Every time I download a new version of your (wondeful) datacenterview, I have to modify those two files to have my network equipments displayed in the correct color (and not the reserved green for unknown device types).

Could you be kind enough to add that change upstream ?

TIA,

Schirrms (Doing his first pull request :))

Molkobain commented 4 years ago

Hello @Schirrms ,

Thanks for the PR and congratulations on your first one! 🎉

Unfortunately I can't really merge this PR for 2 reasons:

The GenericCommDevice isn't part of the standard DataModel and the extension so it would be a bit weird to include it as it seems to be specific to your "Generic Connection" extension.
There is already a customization option in the extended version of the extension. It's parts of the benefits of having the extended version.

That being said, we could totally make a "bridge" extension for people having both our extensions! There is already something similar for TeemIP here.

If you like the idea, I can make the extension (or if you prefer to do it yourself let me know) 😊

Cheers, Guillaume

Schirrms commented 4 years ago

Hello @Schirrms ,

Thanks for the PR and congratulations on your first one! :)

...

That being said, we could totally make a "bridge" extension for people having both our extensions! There is already something similar for TeemIP here.

Hi Guillaume,

Sorry for the late answer...

In fact, I have already my own 'bridge extension for your datacenterview :

https://github.com/Schirrms/iTop-Generic-Connection-To-Datacenter-View

This extension does somehow the same thing that the bridge you proposed. But, to my knowledge, I don't see a way to alter or 'overload' some css/scss indformation here. If you have some hints, I would be more than happy to integrate that colors changes in my existing extension (that would be the effective way to do that work).

TIA,

Pascal

Molkobain commented 4 years ago

Great! Putting those changes in this extension makes perfect sense then. May I make a PR on your repo to bootstrap you so can have these changes? 🤩

Guillaume

Molkobain commented 4 years ago

PR done on your repo here! Thanks for the idea :)