Closed matrulda closed 2 years ago
Base: 0% // Head: 0% // No change to project coverage :thumbsup:
Coverage data is based on head (
b187598
) compared to base (e44042e
). Patch has no changes to coverable lines.:exclamation: Current head b187598 differs from pull request most recent head b0f4f56. Consider uploading reports for the commit b0f4f56 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @mikaelamo and @Aratz for the reviews :pray: ! @Aratz if you could just check the last commit to make sure I didn't introduce anything weird, I think we are good to go.
Looks good, great job :+1:
Also I just noticed Python is now introducing match statements in version 3.10, so I guess in the future this will become the canonical way of writing this kind of code.
Good input @Aratz, I'm not sure how to handle the >= 14
condition using match case though. :thinking: Do you have an idea? Otherwise I think I'll keep it like this.
I'd write case x if x >= 14:
, but I think it's good as it is now, we don't use Python 3.10 yet do we?
Ah ofc, thanks, @Aratz ! I went ahead and upgraded to py3.10 since it required very few changes.
Hmm, I had to update the ubuntu version for travis to be able to download py3.10. We should make sure that we can install py3.10 on the biotanks before including those changes in the next release.
I removed the py3.10 commits, our old servers can't handle py3.10. Will add those changes in a separate PR so that we can release these changes first.
This PR adds support for special MiSeq flowcells (nano and micro) that generates less data than the standard one.
@mikaelamo It would be nice if you could review the changes in config.yaml since you are familiar with INS-00123. :)