Molmed / checkQC

CheckQC inspects the content of an Illumina runfolder and determines if it passes a set of quality criteria
http://checkqc.readthedocs.io/
GNU General Public License v3.0
25 stars 16 forks source link

Reading default config and have instrument specific pickup of reagent version #19

Closed johandahlberg closed 7 years ago

johandahlberg commented 7 years ago

This PR does to things:

1) It ensures that the default handlers are loaded, unless a handler with the same name has already been defined for that instrument. 2) It allows getting the reagent version to be specified on a per instrument type level. This means that to introduce new instruments one needs to actually add code, which is not optimal, but I think that for now this is the most pragmatic way of solving the problem.

@monikaBrandt Check the TODO tags for where to place the code to check if a run is rapid/highoutput.

codecov[bot] commented 7 years ago

Codecov Report

Merging #19 into master will decrease coverage by 0.27%. The diff coverage is 86.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   85.53%   85.26%   -0.28%     
==========================================
  Files          16       16              
  Lines         408      448      +40     
==========================================
+ Hits          349      382      +33     
- Misses         59       66       +7
Impacted Files Coverage Δ
checkQC/app.py 83.87% <100%> (-0.98%) :arrow_down:
checkQC/config.py 94% <100%> (+1.14%) :arrow_up:
checkQC/run_type_recognizer.py 84% <83.33%> (-3.81%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d5ee9d...56a2479. Read the comment docs.