Molmed / checkQC

CheckQC inspects the content of an Illumina runfolder and determines if it passes a set of quality criteria
http://checkqc.readthedocs.io/
GNU General Public License v3.0
25 stars 16 forks source link

Fixing minor things found when preparing for validation testing #26

Closed johandahlberg closed 7 years ago

johandahlberg commented 7 years ago

I've been fixing a few small things, in preparation for validation testing.

A lot of it cosmetic, improving documentation and output messages. However, I also found and fixed a but which would call read 2, read 3. Since there are a few different things going on here it might be easiest to review this PR commit by commit, instead of looking at the full diff.

codecov[bot] commented 7 years ago

Codecov Report

Merging #26 into master will decrease coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #26     +/-   ##
=========================================
- Coverage   93.54%   93.44%   -0.1%     
=========================================
  Files          16       16             
  Lines         480      488      +8     
=========================================
+ Hits          449      456      +7     
- Misses         31       32      +1
Impacted Files Coverage Δ
...heckQC/handlers/undetermined_percentage_handler.py 95.83% <ø> (ø) :arrow_up:
checkQC/run_type_recognizer.py 94.04% <100%> (ø) :arrow_up:
checkQC/handlers/q30_handler.py 95.45% <100%> (ø) :arrow_up:
checkQC/__init__.py 100% <100%> (ø) :arrow_up:
checkQC/handlers/cluster_pf_handler.py 95.45% <100%> (ø) :arrow_up:
checkQC/parsers/interop_parser.py 97.14% <100%> (+0.71%) :arrow_up:
checkQC/handlers/reads_per_sample_handler.py 96.15% <100%> (+0.15%) :arrow_up:
checkQC/config.py 92% <0%> (-2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 880a934...d0c7a54. Read the comment docs.