Reads per sample handler always report threshold based on one sample per lane

Molmed / checkQC

CheckQC inspects the content of an Illumina runfolder and determines if it passes a set of quality criteria

http://checkqc.readthedocs.io/

GNU General Public License v3.0

25 stars 16 forks source link

Reads per sample handler always report threshold based on one sample per lane #49

Closed matrulda closed 6 years ago

matrulda commented 6 years ago

https://github.com/Molmed/checkQC/blob/35b30acfbf5453283eda90ae245bf9e9e7edb8df/checkQC/handlers/reads_per_sample_handler.py#L48

I noticed that the threshold reported is not based on the number of samples in the lane. This is confusing. It would make more sense to show the value that was evaluated.