Closed b97pla closed 6 years ago
Merging #58 into master will increase coverage by
2%
. The diff coverage is25%
.
@@ Coverage Diff @@
## master #58 +/- ##
====================================
+ Coverage 90% 91% +2%
====================================
Files 18 18
Lines 693 684 -9
====================================
Hits 622 622
+ Misses 71 62 -9
Impacted Files | Coverage Ξ | |
---|---|---|
checkQC/app.py | 87% <0%> (-1%) |
:arrow_down: |
checkQC/web_app.py | 75% <50%> (+13%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 6eab96d...01150d4. Read the comment docs.
Looks good! Perhaps you could add the information about running in a docker container to the docs instead? I think it makes sense to try to keep the README somewhat "minimal" and add additional information in the docs. Does that sound reasonable to you?
ah, makes sense, I didn't think of that. I'll move the instructions. Do you want to keep the index.rst
file to mirror the README or can I add them there?
Either there, or under the development section. Take whichever one you think makes the most sense.
ok, it went into the index.rst
file
This PR removes the
ProcessPoolExecutor
functionality from the web service, basically reducing it to running things in a blocking fashion. The problem with the ProcessPoolExecutor was that it spawned a lot of threads that were left running and wouldn't terminate properly. The most straightforward way to fix it was, for now, to remove the threading.Obviously, there are more elegant ways to solve this so feel free to step up π
In addition, a Dockerfile for running the service in a container has been added.