Closed johandahlberg closed 6 years ago
Merging #67 into master will increase coverage by
1%
. The diff coverage is76%
.
@@ Coverage Diff @@
## master #67 +/- ##
====================================
+ Coverage 91% 92% +1%
====================================
Files 18 19 +1
Lines 688 701 +13
====================================
+ Hits 626 638 +12
- Misses 62 63 +1
Impacted Files | Coverage Δ | |
---|---|---|
checkQC/app.py | 87% <100%> (ø) |
:arrow_up: |
checkQC/runfolder_reader.py | 71% <71%> (ø) |
|
checkQC/run_type_recognizer.py | 92% <89%> (+7%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 231d5b6...76af5e0. Read the comment docs.
Go ahead and merge @MatildaAslin
This adds support for the Illumina iSeq, and also makes some changes to the way that the RuntypeRecognizer works by introducing a separate class for reading the files in the runfolder. This makes this easier to mock in the tests, which makes it easier to test that the correct instrument is returned depending on which type of runfolder is passed in.
The QC criteria that I have added are completely arbitrary, and need to be update.