johandahlberg commented 5 years ago

This changes the behavior of CheckQC to emit a fatal error if there are significantly over-represented indexes. This means that the exit code of the program will not be 0 when this happens.

matrulda commented 5 years ago

Do you want @b97pla to look at it too or can I merge, @johandahlberg ?

johandahlberg commented 5 years ago

Wait with merging a second. I have a fix for #78 incoming.

codecov[bot] commented 5 years ago

Codecov Report

Merging #80 into master will decrease coverage by 1%. The diff coverage is 95%.

@@          Coverage Diff          @@
##           master   #80    +/-   ##
=====================================
- Coverage      92%   92%   -<1%     
=====================================
  Files          22    22            
  Lines         934   970    +36     
=====================================
+ Hits          855   885    +30     
- Misses         79    85     +6

Impacted Files	Coverage Δ
checkQC/__init__.py	`100% <100%> (ø)`	:arrow_up:
checkQC/handlers/unidentified_index_handler.py	`93% <95%> (-2%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aae3a03...f741a80. Read the comment docs.

johandahlberg commented 5 years ago

Go ahead and merge.

Molmed / checkQC

Fail on index error #80

Codecov Report