Molmed / checkQC

CheckQC inspects the content of an Illumina runfolder and determines if it passes a set of quality criteria
http://checkqc.readthedocs.io/
GNU General Public License v3.0
25 stars 16 forks source link

DEVELOP-641 Downgrade error level #84

Closed matrulda closed 5 years ago

matrulda commented 5 years ago

This PR adds to option to downgrade errors to warnings for specific handlers.

TODO: Make it possible to use this parameter through the web app.

Sharing this early so you can let me know if you have any thoughts on the solution.

EDIT: 191009 Downgrade error logic was moved to config.py and the functionality has been added to the web app too. This is ready for merge.

codecov[bot] commented 5 years ago

Codecov Report

Merging #84 into master will increase coverage by 1%. The diff coverage is 96%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #84   +/-   ##
=====================================
+ Coverage      92%    92%   +1%     
=====================================
  Files          22     22           
  Lines         983   1001   +18     
=====================================
+ Hits          897    916   +19     
+ Misses         86     85    -1
Impacted Files Coverage Δ
checkQC/web_app.py 81% <100%> (+2%) :arrow_up:
checkQC/config.py 92% <100%> (+2%) :arrow_up:
checkQC/app.py 90% <80%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64a5ccc...9bd5109. Read the comment docs.

johandahlberg commented 5 years ago

This looks good! I guess the next step is to bring this into the webserver as well?

matrulda commented 5 years ago

Thanks! Yeah, working on it right now. :+1:

matrulda commented 5 years ago

Something like this @johandahlberg ? This implementation only supports downgrading errors for one handler though, maybe that's fine?

EDIT It actually works for multiple handlers too: curl http://localhost:9999/qc/<runfolder>/downgrade_errors\=\ReadsPerSampleHandler,UndeterminedPercentageHandler

Adding a test for that.

matrulda commented 5 years ago

@johandahlberg I tried naming of capture groups like we talked about, but it didn't work and I found little help docs (and on the internetz). The current solution works and is pretty clean, imo.