search

MolotovCherry / virtual-display-rs

A Windows virtual display driver to add multiple virtual monitors to your PC! For Win10+. Works with VR, obs, streaming software, etc
MIT License
473 stars 39 forks source link

Replace `env_logger` dependency with `env_filter` #98

Closed kylewlacy closed 3 months ago

kylewlacy commented 3 months ago

I noticed in VS Code that I was getting errors on the master branch around the env_logger feature (I believe I have my Rust Analyzer is configured to check all features by default).

I did some digging and it looks like the build has been broken when the env_logger feature is enabled for a while. I believe it started in #75, which updated env_logger from 0.10.1 to 0.11.0. The release notes for env_logger noted that the filter module was removed, in favor of the new env_filter crate. It looks like the CI/CD pipeline doesn't test the env_logger feature, so this breakage went unnoticed.

I updated the Rust code to use env_filter in place of env_logger. This also means the feature is now called env_filter (e.g. cargo check --features env_filter).

MolotovCherry commented 3 months ago

Looks like we got a missed check! Thanks for noticing!