Molunerfinn / hexo-theme-melody

:musical_keyboard:A simple & beautiful & fast theme for Hexo.
https://molunerfinn.com
Other
1.59k stars 213 forks source link

feature request: upgrade to Font Awesome Version 5 #131

Closed Xeonacid closed 6 years ago

Xeonacid commented 6 years ago

I want to create a new issue

Melody Information

Melody Version: v1.5.6

Feature Request

Font Awesome has upgraded to Version 5. It adds some cool features. Could we upgrade it? Upgrading from Version 4 should help.


I love hexo-theme-melody! Starred.

Molunerfinn commented 6 years ago

I'll check it in few days

:octocat: From gitme iOS

Xeonacid commented 6 years ago

@Molunerfinn Thanks!

upupming commented 6 years ago

How about just using the latest version's CDN in your melody.yml? Like below:

# cdn for third-party library
# ---------------
cdn:
  css:
    fontawesome: https://cdn.jsdelivr.net/npm/font-awesome@latest/css/font-awesome.min.css

The docs says:

Version 4 just had one prefix — fa. Version 5 has four prefixes to let us set the style of any icon easily:

<i class="fa fa-camera-retro"></i>  <!-- version 4's syntax -->

<i class="fas fa-camera-retro"></i> <!-- version 5's syntax -->
<i class="far fa-camera-retro"></i> <!-- example: regular style of camera-retro -->
<i class="fal fa-camera-retro"></i> <!-- example: light style of camera-retro -->

I have tested the Version 5, it seems compatible with the icons melody are using. Could I create a pull request for this minor change?

Molunerfinn commented 6 years ago

@upupming Sure!

Xeonacid commented 6 years ago

Great, thank you all!