script to judge 'ture' is a ture seems to not working - Githubissues

Molunerfinn / hexo-theme-melody

:musical_keyboard:A simple & beautiful & fast theme for Hexo.

https://molunerfinn.com

Other

1.59k stars 213 forks source link

script to judge 'ture' is a ture seems to not working #277

Closed sheey11 closed 4 years ago

sheey11 commented 4 years ago

I want to create a new issue

[x] Yes, I have read FAQ.
[x] Yes, I have read Hexo Docs page, especially Templates, Variables, Helpers and Troubleshooting.
[x] Yes, I have read Hexo-theme-melody Documentation.
[x] And yes, I already searched for current issues and this did not help me.

Melody Information

Melody Version: 1.7

Platform: macos

Browser: chrome

Expected behavior

Behave as it should.

Actual behavior

Steps to reproduce the behavior

Feature Request

I found this in the script: https://github.com/Molunerfinn/hexo-theme-melody/blob/778ed650200768a25bac3e950c7d1e787df20e07/layout/includes/comments/valine.pug#L7 And I set it to true but it's value is still false. Then I tried this:

Screen Shot 2020-04-04 at 2 42 41 PM

Is it my fault or the theme?

Molunerfinn commented 4 years ago

It's a bug of theme. Need to fix:

var verify = '#{ theme.valine.verify }' == 'true' ? true : false;

PR welcome~