MomX / Momocs

:dove: Morphometrics using R

http://momx.github.io/Momocs/

51 stars 18 forks source link

update PCcontrib example to access the ggplot object in the list output #202

Closed benmarwick closed 5 years ago

benmarwick commented 5 years ago

Because the current example gives an error in Momocs_1.2.9:

gg <- PCcontrib(bot.p, nax=1:8, sd.r=c(-5, -3, -2, -1, -0.5, 0, 0.5, 1, 2, 3, 5)) gg + geom_polygon(fill="slategrey", col="black") + ggtitle("A nice title") Error in gg + geom_polygon(fill = "slategrey", col = "black") + ggtitle("A nice title") : non-numeric argument to binary operator

codecov-io commented 5 years ago

Codecov Report

Merging #202 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   12.54%   12.54%           
=======================================
  Files          58       58           
  Lines        8072     8072           
=======================================
  Hits         1013     1013           
  Misses       7059     7059

Impacted Files	Coverage Δ
R/gr-PCA.R	`4.24% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60436e5...d117e14. Read the comment docs.

vbonhomme commented 5 years ago

Thanks a lot!

benmarwick commented 5 years ago

Seems that you didn't merge the changes, only closed the PR? Just curious if that was your intention or an accident. Thanks

vbonhomme commented 5 years ago

An accident ! Not github fluent though i should be. Gonna do it asap, afk these days

Le 8 août 2018 à 02:10, Ben Marwick notifications@github.com a écrit :

Seems that you didn't merge the changes, only closed the PR? Just curious if that was your intention or an accident. Thanks

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

benmarwick commented 5 years ago

Cheers, thanks for the quick reply!