search

MomX / Momocs

:dove: Morphometrics using R
http://momx.github.io/Momocs/
51 stars 18 forks source link

coo_centsize: 'mean(sqrt(...' #208

Closed Almond-S closed 4 years ago

Almond-S commented 4 years ago

Hi Vincent, firstly, thanks for providing that amazing package!!! In the function coo_centsize.default, I wonder about your defintion of the centroid size: https://github.com/MomX/Momocs/blob/2e18272432f94164060b4d068dcb6f12d55f16e3/R/coo-utilities.R#L2507 I would have expected sqrt(mean(... instead of mean(sqrt(... as this would correspond to the defintion of Dryden and Mardia 2012 (times constant) and to what I'd consider standard in shape analysis. Sorry, if I'm wrong, but is this maybe supposed to be the other way? Thanks and cheers, Almond

vbonhomme commented 4 years ago

Hi Almond You're right, thanks a lot. In my everyday work I almost never use it (just like pretty much everything landmarks), so I'm glad you're here ;-) I'm reviewing all Momocs these days and I have to resubmit a version soon, so I'll correct it. best

Almond-S commented 4 years ago

Oh perfect, thank you, and thanks for your quick reply!

vbonhomme commented 4 years ago

See https://momx.github.io/Momocs2/reference/get_centsize.html