search

MomenSherif / react-oauth

Google OAuth2 using the new Google Identity Services SDK for React 🚀
https://www.npmjs.com/package/@react-oauth/google
MIT License
1.13k stars 141 forks source link

fix: allow width to be string or number for google login button #278

Closed MomenSherif closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **react-oauth** | ⬜️ Ignored ([Inspect](https://vercel.com/momensherif/react-oauth/DnRh75NcNtMjGtUbVPtF18Uvsng3)) | | Jul 24, 2023 9:51pm |
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: f877ee68fe8b37afcb6f7446cd975b1ff53484d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | @react-oauth/google | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

marco0212 commented 1 year ago

@MomenSherif why did you add the number type to width?

MomenSherif commented 1 year ago

Google gsi script serve different version for different regions for some reason

There was a version validate the width to be a number only and breaks the code in Brazil and other countries

marco0212 commented 1 year ago

Oh thanks, I also suffered an error in the renderButton method. How did you catch the difference? I could'n find original Google gsi script

MomenSherif commented 1 year ago

Metabase reported it

https://github.com/metabase/metabase/issues/32602