Momentlabs / athenaeum

Jupyter Notebooks as a service
1 stars 0 forks source link

Helm updates and what gets restarted when needs better looking at. #30

Open jdrivas opened 6 years ago

jdrivas commented 6 years ago

Some of this is nicely documented in the z2jh code.

A comment from a commit for example: commit 4bdf67cb0ed68723e96f6904c1022eeb22ced5a7 Author: Erik Sundell erik.i.sundell@gmail.com Date: Wed Jun 6 18:36:35 2018 +0200

chart/heritage removed from template labels

A Deployment controls pods. These pods should not be considered to have a `heritage: tiller`, only the Deployment itself. If the template spec of these pods change, the Deployment will restart them, even though it is just a label to be added... Because of this, the "chart" label containing the chart version is removed, so a helm upgrade does not force a restart of the controlled pods.