search

MomentsLD / moments

MIT License
10 stars 3 forks source link

Possible errors from scipy's nnls optimization in newer scipy versions #147

Open apragsdale opened 9 months ago

apragsdale commented 9 months ago

Making a note here: We may need to update our usage of scipy's nnls optimization, in the admixture function in Manips. It may have changed from scipy 1.11 to 1.12, but this will take some testing.

This was noticed in errors in tests on PR #146. I have scipy 1.11 installed locally, but 1.12 was installed in the PR checks.

apragsdale commented 9 months ago

I added a work-around in PR #146, but may result in some cases where the nnls errors out. So I'll leave this issue open in case scipy 1.12 nnls function calls present any problems.