search

MommyHeather / AdvancedBackups

BSD 3-Clause "New" or "Revised" License
26 stars 4 forks source link

Bug report : Cannot start an instance with Advanced Backups and Hexerei #24

Closed NielsPilgaard closed 10 months ago

NielsPilgaard commented 11 months ago

Describe the bug

Exception in thread "main" java.lang.module.ResolutionException: Modules advancedbackups and com.google.gson export package com.google.gson.stream to module hexerei

I wasn't able to see this error until I toggled the option to open the output log when Minecraft starts.

To Reproduce Steps to reproduce the behavior:

  1. Make a tiny modpack with Advanced Backups (+dependencies) and Hexerei (+dependencies)
  2. Launch it
  3. See error

Expected behavior For the game to start

Screenshots If applicable, add screenshots to help explain your problem.

Versioning (please complete the following information):

Entire log, from the output window of the Minecraft launcher: https://gist.github.com/NielsPilgaard/85fe51af1c1d32fc95e9fe6a16d76ca3

MommyHeather commented 11 months ago

Thank you, I'll look into this... just to check, do you experience this with an older version? AdvancedBackups-forge-1.19-2.1.zip

I've attached version 2.1 - unavailable on curseforge, so if you wanted to grab from there you'd need 2.0. If the issue doesn't occur here, it basically tells me exactly what's at fault.

(I likely won't be able to try a repro today, but will do so tomorrow)

MommyHeather commented 11 months ago

Nevermind. Confirmed repro, potentially a confirmed fix...

MommyHeather commented 11 months ago

Curseforge awaiting approval, modrinth.. approved already? Let me know if you're having any further issues, but none should be encountered.

New mod version is 2.1.3.

MommyHeather commented 11 months ago

Okay, all files except 1.16 got flagged for manual review for some reason... That could take a few days.

In the meantime, all files are available from modrinth or the latest Build All Mod Jars workflow.

image

Issue re-opened for tracking's sake

NielsPilgaard commented 10 months ago

Thanks for the swift fix 😊

MommyHeather commented 10 months ago

Thanks for the swift fix 😊

No problem! Thanks for the report haha

MommyHeather commented 10 months ago

Seems a bunch of older files have retroactively been put into manual review too... No word from CF about it, but I think it's due to the fact that 2.0 and newer write batch scripts - given the recent mods that were downnloading and running malicious scripts, I imagine they're manually reviewing all mods that also interact with bat scripts?

Do you want me to keep you updated on this? @NielsPilgaard

NielsPilgaard commented 10 months ago

Yes please :)

MommyHeather commented 10 months ago

Small update - the older files have been reverified, seems they weren't meant to be put into manual review - as for the newer ones, apparently one of the classes failed to decompile. We've confirmed the class can be decompiled with no issues so I'll see where it goes from there

MommyHeather commented 10 months ago

All approved! Closing as everything should be resolved now. @NielsPilgaard