MommyHeather / AdvancedBackups

BSD 3-Clause "New" or "Revised" License
26 stars 4 forks source link

Questions about commands #28

Closed NielsPilgaard closed 10 months ago

NielsPilgaard commented 10 months ago

I'm wondering, what do the following commands do?

Another note, perhaps it would be best to rename the reload config command to reload-config or similar. Reload is a bit vague to me.

Additionally, I recommend using /backup instead of /advancedbackups, since /backup is the norm. Or add an alias, if that's.. a thing.

MommyHeather commented 10 months ago

These are documented - do you think this needs clarifying (or some other adjustments?)

And yeah, I guess I'll rename the command - I had it named the way it was as I didn't want to risk conflict with other mods, in the event that someone has both advancedbackups and another backup mod installed.

MommyHeather commented 10 months ago

Perhaps check and force-backup should be removed, and start should just ignore the checks...?

NielsPilgaard commented 10 months ago

These are documented - do you think this needs clarifying (or some other adjustments?)

I think adding a wiki link to the CurseForge page would be helpful (and a CurseForge link to the GitHub README)

Perhaps check and force-backup should be removed, and start should just ignore the checks...?

I think that's a good idea 👍

MommyHeather commented 10 months ago

I think adding a wiki link to the CurseForge page would be helpful (and a CurseForge link to the GitHub README)

Github is linked on curseforge / modrinth - but yeah, i should get a curseforge + modrinth link here.

NielsPilgaard commented 10 months ago

You can add a Wiki link so it actually displays "Wiki" at the top, along description, source etc

MommyHeather commented 10 months ago

Good point. I'll do that too.

MommyHeather commented 10 months ago

So, this is now all done - can you think of anything else needed, or should I release v2.2?

NielsPilgaard commented 10 months ago

I think we're good to go 👍

MommyHeather commented 10 months ago

Awesome! I'll get it on curseforge/modrinth when built then - CF may take some time to approve, MR has been pretty quick in my experience