search

MommyHeather / AdvancedBackups

BSD 3-Clause "New" or "Revised" License
21 stars 5 forks source link

Bug report : Cannot use CLI tool to restore world #29

Closed NielsPilgaard closed 9 months ago

NielsPilgaard commented 9 months ago

Describe the bug While testing AB, I went into my singleplayer world "New World". I have 2, the other is called "Creative" I ran all AB commands, including start and force-backup. This produced 2 full differential backups. I then left the world, and deleted the contents of the save, but not the "New World" folder within the saves folder.

I then ran the restore.bat script to execute the jar. Here's a screenshot of my interaction with the CLI: image

Expected behavior For me to be able to restore my world with the CLI tool.

Screenshots If applicable, add screenshots to help explain your problem.

Versioning (please complete the following information):

Additional context Add any other context about the problem here.

MommyHeather commented 9 months ago

I see what's happened - the tool checks for the presence of level.dat to determine what is and isn't a world. I'll get some more feedback regarding world numbers - to be honest, I hadn't even considered that people would delete world contents before trying to restore. The export option would still create a usable zip, but I do understand why that might not be ideal...

I'm not 100% certain what the best course of action here is - what do you think? As backups can be made for multiple worlds, I do use the world dir as a filter - but when it can't find your world due to the lack of level.dat, only the export option would work there...

MommyHeather commented 9 months ago

As a side note, the filtering exists after someone requested #4 via discord. I'm in favour of keeping it, and it's part of why the export option does exist - but I get why that might not be perfect.

NielsPilgaard commented 9 months ago

Oh, d'oh 😅 perfectly fine then, I thought I was supposed to delete the contents of the folder first, I may or may not have read some of the manual restore steps and mixed them 😄

MommyHeather commented 9 months ago

Haha fair enough

Do you think the instructions are clear enough or do they need adjusting?

NielsPilgaard commented 9 months ago

I think they're overly verbose to be honest 🤔

MommyHeather commented 9 months ago

I think they're overly verbose to be honest 🤔

Might be the case. I'm not good at explaining, so I wouldn't be surprised... you got any suggestions for an edit?

MommyHeather commented 9 months ago

Still not really sure how to improve, but I did make #30 to attempt an improvement haha

NielsPilgaard commented 9 months ago

I tried 😅 https://github.com/MommyHeather/AdvancedBackups/pull/31 User-facing documentation is hard...