search

MommyHeather / AdvancedBackups

BSD 3-Clause "New" or "Revised" License
21 stars 5 forks source link

Bug report : 1.19.4 Quilt server crashes after startup #45

Closed JadieMae23 closed 8 months ago

JadieMae23 commented 8 months ago

Describe the bug My 1.19.4 Quilt server crashes right after loading because of a NullPointerException, which it encounters again upon trying to shut down(when the mod's configured to back up on shutdown).

To Reproduce Steps to reproduce the issue:

  1. Set up a Quilt server with the installer's GUI exactly as detailed by its download page, then agree to the Minecraft EULA as usual.
  2. Add the Quilted Fabric API/Quilt Standard Libraries bundle to the mod folder as the installer asked, along with Advanced Backups.
  3. (Optional) In AdvancedBackups.properties, set config.advancedbackups.frequency.shutdown to 'true'.
  4. Run the .bat file you created(java -jar quilt-server-launch.jar nogui) in the server's root directory again.
  5. Wait for the server to load.
  6. Immediately after the server finishes and reports load time you should see a crash. In case you followed step 3, you should also see the server fails to stop properly due to the same error.

Expected behavior Normally the server will not show any errors after the "Dedicated server took x seconds to load" message.

Screenshots Without backups on shutdown:

image

With backups on shutdown:

image

Versioning (please complete the following information):

Additional context I can say with certainty that the mod works just fine for another (Forge 1.18.2)server I'm hosting on the same machine.

MommyHeather commented 8 months ago

Confirmed repro on quilt, seems that a fabric modloader method is returning an invalid value. I'll look to see if there's a way I can fix this without yet another branch haha

MommyHeather commented 8 months ago

Should have a fix pushed tonight, in theory.

MommyHeather commented 8 months ago

AdvancedBackups-fabric-1.19.3-3.2.2-rc1.zip

@JadieMae23 could you test this on your end before I see about pushing it to curseforge / modrinth? It's done the job on my end.

JadieMae23 commented 8 months ago

I can confirm it works on my end as well. Thank you for the swift response!

MommyHeather commented 8 months ago

Awesome. I've now checked this on other fabric branches, looks like i'm good to release.