search

Mon-Ouie / pry-remote

Connect to Pry remotely
Other
639 stars 81 forks source link

Missing current session history #40

Closed vwoo closed 11 years ago

vwoo commented 11 years ago

After running pry-remote I'll run a few commands but they won't show up when pressing the up arrow key. Only the history from previously exited pry-remote usage will show up.

Secondly, after pressing the up arrow key, the entire command prompt will get overridden by the history command.

None of these strange behaviours occur when using pry alone. Any ideas on how to fix this?

My setup: OSX 10.8.4 ruby 2.0.0p247 rails 3.2.14 pry 0.9.12.2 pry-remote 0.1.7

Mon-Ouie commented 11 years ago

This is because I'm changing the input object used by Pry and so it no longers tells Readline to add new entries to the history (which requires an explicit second argument). I special-cased Readline in commit 98be7896, which should fix your issue.

vwoo commented 11 years ago

Thanks, that fixed it!

DelawareConsulting commented 10 years ago

Dear @Mon-Ouie ,

Can you explain how to implement your fix to my environment?

Kind regards.

Mon-Ouie commented 10 years ago

You could either build the gem from git (gem build pry-remote.gemspec && gem install pry-remote-0.1.8.gem), or update your gem since I just pushed an update.

zph commented 10 years ago

@Mon-Ouie Thank you so much for fixing this issue!

gotoAndBliss commented 10 years ago

Thank you @Mon-Ouie for fixing the issue!