Monad-Pad / gmon.link

gmon.link is the easiest and quickest way to aggregate links for projects or individuals.
https://gmon.link
MIT License
6 stars 16 forks source link

bug: wrong button link insertion and link and opening the links in a new tab #5

Closed jeonghoyeo7 closed 1 month ago

jeonghoyeo7 commented 1 month ago

Is there an existing issue for this?

Current Behavior

There are two issues:

  1. When a user types links to the button, depending on http://, wrong addresses can be inserted. If a user does not type http:// then https://gmon.link/ is added. image image
image image 2. When a user clicks the link of the button, then the site is opened in the same tab, not the new tab. ### Expected Behavior 1. When a user types links to the button, regardless of `http://`, correct addresses should be inserted. 2. When a user clicks the button, the link needs to be opened in the new tab. ### Steps To Reproduce 1. A user can insert the button link in telegram without `http://` e.g., `google.com`, then the button link becomes `https://gmon.link/google.com` 2. A user clicks the button, the site is opened in the same tab. ### Anything else? Solution 1. This can be handled as exceptions in the telegram bot. 2. This can be fixed by adding `target="_blank"`.
elliotdotsol commented 1 month ago

Great issue, your PR was merged successfully