Monadical-SAS / stacker-scaffold-node

1 stars 0 forks source link

Enhancement options #1

Open kevincardonag opened 1 year ago

kevincardonag commented 1 year ago

Context: We want to improve our hiring process related to the time developers spend writing code for their interviews, we want to provide applicants with a code base where they can simulate working on a project that has already been developed.

Purposes of this ticket:

These differences were found:

  1. In the node app you can select the player, it is a bit confusing when users try to start a game and It also has a disadvantage because the second player could enter to a player1’s room, so I think is better to have a username text field to avoid to enter to the wrong room.

image

  1. We are missing copy game id button in node project

image

  1. Minor changes
    • Add “side stacker” title as in the python project (see the image above)
    • When the game ends display an alert with winner's name and then return to the main page
    • Make sure it is no possible to enter a game without player name and game ID
dearlordylord commented 1 year ago

For the "copy game id" feature, pay attention to whether it'll work with a non-HTTPS address. I remember experiencing issues there on HTTP, which could be every applicant's environment