Monash-Connected-Autonomous-Vehicle / ESDA

Software stack for MCAVs annual IGVC entry
0 stars 0 forks source link

Clean up repository #33

Closed AbBaSaMo closed 8 months ago

AbBaSaMo commented 8 months ago
AbBaSaMo commented 8 months ago

@dylan-gonzalez

With regards to the submodules currently existing in the ESDA repository, the following packages are listed in the rosdistro repository under the humble distribution file:

My assumption is that I don't necessarily need to apt install them but that I can include them in our esda_launch packages packages.xml file as a dependency in which case running rosdep install will do that for us and then launch the relevant drivers in our sensors launch file that point to custom config files as discussed on slack.

The following are not listed in rosdistro and I can't seem to find them as apt packages

With the zed-ros2-wrapper I'll need to likely modify the URDF files they provide so I'm assuming keeping it as a submodule of a fork will remain suitable.

Regarding swiftnav-ros, would best practice entail also keeping it as a submodule or installing it via some other means? e.g. the below screenshot or is this convoluted?

Image

AbBaSaMo commented 8 months ago

@dylan-gonzalez

All done, nice and clean! Haven't tested with the sensors hooked up though but merged to main anyway.

Image

AbBaSaMo commented 8 months ago

Need to look into this

Image

Image

AbBaSaMo commented 8 months ago

@Monash-Connected-Autonomous-Vehicle/avp-team

image

Anyonw know how I can find where this would be i.e. [WARNING] [launch_ros.actions.node]: Parameter file path is not a file: .

Looked into all launch files but nothing found

AbBaSaMo commented 8 months ago

Dylan says . represents a dir and that it shouldn't be an issue. All nodes using a config are working at least, so going to close issue and merge progress to main